AY2122S1-CS2103T-F12-2 / tp

https://ay2122s1-cs2103t-f12-2.github.io/tp/
MIT License
1 stars 5 forks source link

Branch dg update #216

Closed yunpeng1234 closed 3 years ago

yunpeng1234 commented 3 years ago

image

image

image

image

Might be the same as @Chang-CH pr but just to compare see if they are right

codecov-commenter commented 3 years ago

Codecov Report

Merging #216 (cc7653a) into master (8039fbe) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #216   +/-   ##
=========================================
  Coverage     70.51%   70.51%           
  Complexity      595      595           
=========================================
  Files            85       85           
  Lines          1923     1923           
  Branches        259      259           
=========================================
  Hits           1356     1356           
  Misses          448      448           
  Partials        119      119           
Impacted Files Coverage Δ
src/main/java/seedu/intern/ui/ApplicantCard.java 0.00% <0.00%> (ø)
...ain/java/seedu/intern/ui/ApplicantDetailPanel.java 0.00% <ø> (ø)
.../main/java/seedu/intern/ui/ApplicantListPanel.java 0.00% <0.00%> (ø)
src/main/java/seedu/intern/ui/MainWindow.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8039fbe...cc7653a. Read the comment docs.

yunpeng1234 commented 3 years ago

Guys help check the UML diagram thanks

Jeromesyl commented 3 years ago

For Model, there should be a VersionedInternWatcher that inherits from InternWatcher. VersionedInternWatcher actually replaces InternWatcher in ModelManager, so I think that the associations from ModelManager and UniquePersonList should be connected to VersionedInternWatcher instead?

Chang-CH commented 3 years ago

There are still traces of person. I already have edited PUML's on my PR.

yunpeng1234 commented 3 years ago

New Diagrams

DeleteSeq image

DeleteAllSeq image

EditAllSeq image

ModelClass image