DG check - Githubissues

jackgugz commented 3 years ago

Jeromesyl commented 3 years ago

Our Acknowledgement section is empty. I think we can add the libraries we used at least. Eg. Libraries used: JavaFX, Jackson, JUnit5

Chang-CH commented 3 years ago

[ ] We could delete the Setting up, getting started part
[x] #Design puml tip is probably not meant to be there.
[x] links are all incorrect. for example, Line 39 Main has two classes called Main and MainApp. links to the se-edu Main and MainApp etc.
[x] Font size of some PUML files, e.g. delete, edit sequence diagrams, are too small. can look into editing the css to make the side margins thinner?
[x] Line 110 PUML references AddressBookParser
[x] line 119 diagram is now too small due to us having too many attribute. May have to increase width in inline <img> tag.
[x] line 131 width too low
[x] line 140 image references JsonAdaptedTag, should be JsonAdaptedSkill
[x] line 187 activity diagram too small
[x] Line 194, image filename not updated, should be images/EditAllSequenceDiagram.png.
[x] Line 206, need an extra newline, GFMD is joining the lines
[x] Line 221, should be of all fields
[x] {More to be added} near the end can probably be removed
[x] Private contact detail in glossary never used
[x] line 563 more test cases
[x] line 581 edit references delete
[x] line 618-620 not updated

jackgugz commented 3 years ago

[ ] shows fine on web but its shown on the md file from guthub
[x] links to all such webs are not working
[x] Therefore, with the above consideration and the fact that different applicants sharing same name is relatively rare case. We decided to proceed with alternative 1. change to Therefore, with the above consideration and the fact that different applicants sharing same name is relatively rare case, we decided to proceed with alternative 1.
[x] a new line to start from As internship ...
[x] edit all features recommended to split into multiple graphs
[x] graph for edit all features to be enlarged
[x] sequence diagram for edit all feature is broken
[x] a new line to start for the second aspect
[x] delete all feature: to be split into different paragraphs
[x] change to The filter mechanism is facilitated by FilterCommandParser. FilterCommandParser produces a FilterApplicantDescriptor, which in turn helps to create a FilterCommand.
[ ]
capitalise the S in set
[x] user stories to add in filter/redo/undo/editall/delete all
[x] use cases to add in filter
[x] non functional requirements have the line "more to be added" to be deleted before final submission

Jeromesyl commented 2 years ago

AY2122S1-CS2103T-F12-2 / tp