search

AY2122S1-CS2103T-T09-1 / tp

https://ay2122s1-cs2103t-t09-1.github.io/tp/
MIT License
4 stars 5 forks source link

Code quality #254

Closed mslevis closed 2 years ago

mslevis commented 2 years ago

Shorten long methods and introduce logging in command execution

codecov-commenter commented 2 years ago

Codecov Report

Merging #254 (1244184) into master (7f8dd2c) will increase coverage by 0.29%. The diff coverage is 92.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #254      +/-   ##
============================================
+ Coverage     68.19%   68.48%   +0.29%     
- Complexity      745      749       +4     
============================================
  Files            94       94              
  Lines          2581     2605      +24     
  Branches        346      348       +2     
============================================
+ Hits           1760     1784      +24     
  Misses          763      763              
  Partials         58       58
Impacted Files Coverage Δ
.../seedu/address/logic/parser/ListCommandParser.java 95.65% <0.00%> (-0.19%) :arrow_down:
...a/seedu/address/logic/parser/LogCommandParser.java 90.47% <84.61%> (-0.44%) :arrow_down:
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <100.00%> (ø)
...ava/seedu/address/logic/commands/AliasCommand.java 96.42% <100.00%> (+0.27%) :arrow_up:
...ava/seedu/address/logic/commands/ClearCommand.java 100.00% <100.00%> (ø)
...va/seedu/address/logic/commands/DeleteCommand.java 100.00% <100.00%> (ø)
...java/seedu/address/logic/commands/EditCommand.java 88.78% <100.00%> (+0.11%) :arrow_up:
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <100.00%> (ø)
...seedu/address/logic/commands/FavouriteCommand.java 100.00% <100.00%> (ø)
...java/seedu/address/logic/commands/FindCommand.java 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f8dd2c...1244184. Read the comment docs.