AY2122S2-CS2103-F11-2 / tp

TAlent Assistant™ is a desktop application used by professors to schedule interviews and keep track of applications for teaching assistants.
https://ay2122s2-cs2103-f11-2.github.io/tp/
MIT License
1 stars 5 forks source link

[PE-D] Feedback message can be clearer #340

Closed soc-pe-bot closed 2 years ago

soc-pe-bot commented 2 years ago

It is noticed that when adding a candidate, the application does not allow adding the candidate if the value in one of the id, phone or email fields already exist in another candidate's records. However, as the same feedback message ('This candidate already exists in the system') is used regardless of which field contains the duplicate value, it may be difficult for the user to identify exactly which fields may have been entered incorrectly.

For example, when entering add id/A0132435E n/ABC p/94231537 e/e0123456@u.nus.edu c/Information Security yr/1 avail/5 and there already exists a record with that same email, it may be difficult to tell that the duplicate value is in the email (unless the user uses the focus command to go through every candidate).

image.png

A suggestion is to be more detailed in the feedback message to inform the user exactly which fields may be incorrect. And if all fields (id, email, name, phone) are the exact same as another record, the feedback message ('This candidate already exists in the system') can be displayed.


Labels: type.FeatureFlaw severity.Medium original: nicollegann/ped#4

domlimm commented 2 years ago

To add in UG candidate's PK.