search

AY2122S2-CS2103-F11-2 / tp

TAlent Assistant™ is a desktop application used by professors to schedule interviews and keep track of applications for teaching assistants.
https://ay2122s2-cs2103-f11-2.github.io/tp/
MIT License
1 stars 5 forks source link

Schedule Feedback Bug #366

Closed tiewweijian closed 2 years ago

tiewweijian commented 2 years ago

Bugs reported:

343

  1. focus 2
  2. schedule add candidate/2 at/04-04-2022 11:00
  3. schedule clear

Error message was displayed incorrectly. This was due to the fact that the schedule was cleared first, no longer able to get the Candidate from the InterviewList

315

schedule clear when the user types view today with an empty list. This is also related to #343, as the updated InterviewList is empty, unable to retrieve Candidate from the updated InterviewList.

In this PR, I have ensured to get the index of the Candidate before deleting them. It works on my end now!

Closes #343 Closes #315

codecov[bot] commented 2 years ago

Codecov Report

Merging #366 (f96a546) into master (90938e5) will decrease coverage by 0.05%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #366      +/-   ##
============================================
- Coverage     70.58%   70.52%   -0.06%     
  Complexity      862      862              
============================================
  Files           125      125              
  Lines          2648     2650       +2     
  Branches        363      364       +1     
============================================
  Hits           1869     1869              
- Misses          670      672       +2     
  Partials        109      109
Impacted Files Coverage Δ
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90938e5...f96a546. Read the comment docs.