search

AY2122S2-CS2103-F11-2 / tp

TAlent Assistant™ is a desktop application used by professors to schedule interviews and keep track of applications for teaching assistants.
https://ay2122s2-cs2103-f11-2.github.io/tp/
MIT License
1 stars 5 forks source link

Issues #386, #393: Update DG on `Model` component #403

Closed domlimm closed 2 years ago

domlimm commented 2 years ago

@lzan98 leon tagging you to review because you're more familiar with the Interview portion to verify the model. Thanks! ❤️

Closes #386. Closes #393.

codecov[bot] commented 2 years ago

Codecov Report

Merging #403 (a155574) into master (5e78aeb) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #403   +/-   ##
=========================================
  Coverage     72.04%   72.04%           
  Complexity      865      865           
=========================================
  Files           122      122           
  Lines          2604     2604           
  Branches        359      359           
=========================================
  Hits           1876     1876           
  Misses          637      637           
  Partials         91       91

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e78aeb...a155574. Read the comment docs.

domlimm commented 2 years ago

Hey Dom! The diagram might require another InterviewSchedule class and ReadOnlyInterviewSchedule because AddressBook only stores the candidates!

Noted! Let me make the changes now and get your review again. Will notify you via tele!

domlimm commented 2 years ago

@lzan98 hello sir! changes are up as per our discussion. thanks!!! 😍