search

AY2122S2-CS2103T-T09-3 / tp

MIT License
0 stars 4 forks source link

Limit Name + Minor refractor(Rating) #315

Closed aweijun closed 2 years ago

aweijun commented 2 years ago

Details

Refractor Rating isValidRating() Limit Name with regrex Add testcase for isValidName()

codecov-commenter commented 2 years ago

Codecov Report

Merging #315 (2fa7c69) into master (024c77a) will decrease coverage by 0.05%. The diff coverage is 60.00%.

@@             Coverage Diff              @@
##             master     #315      +/-   ##
============================================
- Coverage     62.98%   62.93%   -0.06%     
+ Complexity      501      500       -1     
============================================
  Files            88       88              
  Lines          1713     1713              
  Branches        195      195              
============================================
- Hits           1079     1078       -1     
- Misses          552      553       +1     
  Partials         82       82
Impacted Files Coverage Δ
...edu/trackermon/logic/parser/FindCommandParser.java 25.45% <0.00%> (ø)
...java/seedu/trackermon/logic/parser/ParserUtil.java 84.61% <0.00%> (ø)
...rc/main/java/seedu/trackermon/model/show/Name.java 90.90% <ø> (ø)
.../main/java/seedu/trackermon/model/show/Rating.java 94.44% <100.00%> (ø)
...java/seedu/trackermon/storage/JsonAdaptedShow.java 77.50% <100.00%> (ø)
...edu/trackermon/logic/parser/SortCommandParser.java 77.63% <0.00%> (-1.32%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 024c77a...2fa7c69. Read the comment docs.