AY2122S2-CS2113T-T09-3 / tp

0 stars 5 forks source link

[Code review] @Anvitha-r #173

Closed slewyh closed 2 years ago

slewyh commented 2 years ago
  1. Use standard words to name your methods and variables.
    • createArray.. and returnArray... are low-level method names. Screenshot 2022-04-05 at 2 34 41 PM
  1. Remove unused lines of code to increase code quality.

    Screenshot 2022-04-05 at 2 55 26 PM
  2. To refactor comments below

    Screenshot 2022-04-05 at 2 58 34 PM

a. Indent comments relative to their position in code. See standard conventions for comments.

b. Comment minimally but sufficiently. view patient does not explain more on what the code does. How about displays a patient 's full details (name, age, address, etc.) given an NRIC.

  1. Block 1 and block 2 are of different level of abstraction than 3. Consider abstracting them out into separate methods to ensure SLAP. Screenshot 2022-04-05 at 2 39 01 PM