AY2223S2-CS2103-F10-4 / tp

New Fork for TP
https://ay2223s2-cs2103-f10-4.github.io/tp/
MIT License
1 stars 4 forks source link

[PE-D][Tester D] Negative past transaction count #124

Open soc-pe-bot opened 1 year ago

soc-pe-bot commented 1 year ago

I tried to keep adding transaction to the limit and eventually it became negative. I assume you are using int here thats why when it hit the max value of int, it became negative.

Suggestion: It is good to limit the max transaction count.

image.png


Labels: type.FunctionalityBug severity.High original: lyndonlim27/ped#9

jjiayyingtt commented 1 year ago

@seriouslia0 your sum needs to check that the total is less than Long.MAX_VALUE

jjiayyingtt commented 1 year ago

I already changed to long type and limit the increment to take in number less than the max value