AY2223S2-CS2103-F10-4 / tp

New Fork for TP
https://ay2223s2-cs2103-f10-4.github.io/tp/
MIT License
1 stars 4 forks source link

[PE-D][Tester A] Potential Sale Value cannot hold large number #129

Closed nus-pe-bot closed 1 year ago

nus-pe-bot commented 1 year ago

Screenshot 2023-03-31 at 7.50.05 PM.png

Screenshot 2023-03-31 at 7.50.12 PM.png

After key in a large number for Potential Sale Value, terminal display error messages. Although the field looks like being properly updated, it actually affect the summary. summary cannot be opened anymore (for both CLI and button). Please try to set a max number limit for Potential Sale Value.


Labels: severity.High type.FunctionalityBug original: CarrieLi1015/ped#14

ezeAng commented 1 year ago

Now it allows for large sizes and summary still shows, but actual value is reflected as 0 or some very negative value, hence it is being sorted to the bottom when sorted descendingly.

jjiayyingtt commented 1 year ago

Actually it is not possible sort these numbers that have exceeded the max value of long

Now it allows for large sizes and summary still shows, but actual value is reflected as 0 or some very negative value, hence it is being sorted to the bottom when sorted descendingly.

jjiayyingtt commented 1 year ago

I think we'll just limit the value to below the max ah