fix bug in search where 'instagram', 'telegram' and 'whatsapp' are considered part of contact by search

[Lava-Iris]

closes #191

[codecov[bot]]

Codecov Report

Merging #222 (d9105c3) into master (39b4234) will increase coverage by 2.01%. The diff coverage is 53.84%.

@@             Coverage Diff              @@
##             master     #222      +/-   ##
============================================
+ Coverage     64.22%   66.23%   +2.01%     
- Complexity      666      677      +11     
============================================
  Files           100       99       -1     
  Lines          2440     2420      -20     
  Branches        364      352      -12     
============================================
+ Hits           1567     1603      +36     
+ Misses          692      642      -50     
+ Partials        181      175       -6     

Impacted Files	Coverage Δ
...seedu/connectus/model/socialmedia/SocialMedia.java	65.21% <25.00%> (-8.47%)	:arrow_down:
...main/java/seedu/connectus/model/person/Person.java	97.19% <100.00%> (+0.13%)	:arrow_up:

... and 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Lava-Iris]

fix didn't seem to work for me, not sure but i think email and birthday may be causing the same issue?

Can you give an example of a case that doesn't work?

[gremmyz]

Can you give an example of a case that doesn't work?

same case, search i

i think it might be returning everything that has Optional[] or Optional.empty, when i do search em it returns everyone that has at least 1 empty field:

[Lava-Iris]

can you try again?