search

AY2223S2-CS2103T-W15-1 / tp

https://ay2223s2-cs2103t-w15-1.github.io/tp/
MIT License
0 stars 4 forks source link

Prevent future dates in birthday #224

Closed vsamarth closed 1 year ago

vsamarth commented 1 year ago

Closes #196 and #177

codecov[bot] commented 1 year ago

Codecov Report

Merging #224 (7728ed2) into master (50b57e3) will increase coverage by 1.32%. The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master     #224      +/-   ##
============================================
+ Coverage     65.59%   66.92%   +1.32%     
- Complexity      672      689      +17     
============================================
  Files            99       99              
  Lines          2404     2428      +24     
  Branches        346      351       +5     
============================================
+ Hits           1577     1625      +48     
+ Misses          659      629      -30     
- Partials        168      174       +6
Impacted Files Coverage Δ
...in/java/seedu/connectus/model/person/Birthday.java 86.20% <80.00%> (+18.20%) :arrow_up:

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

salty-flower commented 1 year ago

Looks good, but maybe just tell the user "past but < 200 years": image