AY2223S2-CS2103T-W15-1 / tp

https://ay2223s2-cs2103t-w15-1.github.io/tp/
MIT License
0 stars 4 forks source link

Hide optional label in output #225

Closed vsamarth closed 1 year ago

vsamarth commented 1 year ago

I am not sure if it's a cosmetic bug (but i feel like it's a functionality). Adding a new person with let's say only name and phone still shows Optional.empty in the output.

Even where values (like phone no.) is present, it is wrapped around Optional[]

Screenshot 2023-04-08 at 6 17 33 AM
vsamarth commented 1 year ago

@salty-flower @Lava-Iris @gremmyz @Saha9616 any ideas?

I might try to fix this but I just want to make sure it's allowed under v1.4

salty-flower commented 1 year ago

I would consider this as fixing bugs🤔

salty-flower commented 1 year ago

Ono...

Q6: Can we tweak error/help messages (or other text shown to the user)? A: Only if the current text is incorrect (i.e., a bug). Adding more information or otherwise 'enhancing' the text is not allowed.

vsamarth commented 1 year ago

Then I am closing it since we can not fix it in this release.