search

AY2223S2-CS2113-T15-2 / tp

0 stars 5 forks source link

Code Review: Khairul #168

Closed mathanmahe closed 1 year ago

mathanmahe commented 1 year ago

@kairuler

  1. Avoid using magic strings - Line 69, 87, 89. Consider making constant messages that can be called to improve readability.

image

  1. Avoid using magic strings - Line 33,34,36

image

  1. Constant should be in uppercase, using underscore to separate words - Line 13

image

  1. Consider making these final constants, if they are not going to change.

image

ollayf commented 1 year ago

resolved