Closed mathanmahe closed 1 year ago
@ollayf
Line 18 - Consider writing comments to the reader, instead of as a note to self.
Line 20, 25, 30 Comments should be indented relative to their position in code.
Line 207 - Comment minimally but sufficiently. Since code is self explanatory, can consider removing this comment.
Line 35,36,49 - Avoid magic strings. Consider extracting out a constant such as FOLDER_DELIMITER to improve readability and allow reuse.
FOLDER_DELIMITER
Line 99 - Avoid notes to self while commenting and consider rephrasing it to write to the reader.
Final constants hould be in uppercase where each word is separated by an underscore
resolved
ollayf
commented
1 year ago ollayf
commented
1 year ago
@ollayf
Line 18 - Consider writing comments to the reader, instead of as a note to self.
Line 20, 25, 30 Comments should be indented relative to their position in code.
Line 207 - Comment minimally but sufficiently. Since code is self explanatory, can consider removing this comment.
Line 35,36,49 - Avoid magic strings. Consider extracting out a constant such as
FOLDER_DELIMITERto improve readability and allow reuse.Line 99 - Avoid notes to self while commenting and consider rephrasing it to write to the reader.
Final constants hould be in uppercase where each word is separated by an underscore