search

AY2223S2-CS2113-W15-4 / tp

https://ay2223s2-cs2113-w15-4.github.io/tp/
0 stars 5 forks source link

[PE-D][Tester C] [Functionality] Duplicate staff can be added by `add_staff` #145

Closed nus-se-bot closed 1 year ago

nus-se-bot commented 1 year ago

When a person with the same name, birth date and phone number is passed to add_staff multiple times, he/she is added succesfully every single time, as demonstrated below:

image.png

This is not intended behaviour, since people with the same name, birth date and phone number necessarily have to be the same person, and thus should not be added multiple times into any record. That being said, the severity is low, since this is an occasional mistake that users may make, and can be resolved using the delete_staff command.

Labels: type.FunctionalityBug severity.Low original: haoyangw/ped#11

kristianachwan commented 1 year ago

Resolved here by checking before adding staff. https://github.com/AY2223S2-CS2113-W15-4/tp/pull/157