search

AY2223S2-CS2113-W15-4 / tp

https://ay2223s2-cs2113-w15-4.github.io/tp/
0 stars 5 forks source link

[PE-D][Tester C] [Functionality] Invalid parameters allowed by `add_staff` command #149

Closed soc-se-bot closed 1 year ago

soc-se-bot commented 1 year ago

When a non-integer type is passed as the phone number argument to the add_staff command, the command executes successfully, adding an invalid staff record:

image.png

We verify that the staff is indeed added successfully using view_staff:

image.png

However, this is not intended behaviour since phone numbers cannot be non-integer types in any country. That being said, this is a low-severity bug since most users would not make this mistake, and users can resolve the issue using the delete_staff command.

Labels: type.FunctionalityBug severity.Low original: haoyangw/ped#13

kristianachwan commented 1 year ago

https://github.com/AY2223S2-CS2113-W15-4/tp/pull/157 Resolved here. phone number is integer only.