AY2324S1-CS2103T-T08-1 / tp

MIT License
0 stars 5 forks source link

Fix Phone Number Regex #239

Closed kimshitong closed 1 year ago

kimshitong commented 1 year ago

Closes #196

Make it become more restrictive that phone numbers should start with 6, 8, or 9 and be 3 or 8 digits long. eg: 911, 81754211

codecov[bot] commented 1 year ago

Codecov Report

Merging #239 (1634c03) into master (8fd3fc2) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #239   +/-   ##
=========================================
  Coverage     81.04%   81.04%           
  Complexity      938      938           
=========================================
  Files           137      137           
  Lines          2823     2823           
  Branches        275      275           
=========================================
  Hits           2288     2288           
  Misses          502      502           
  Partials         33       33           
Files Coverage Δ
...rc/main/java/seedu/address/model/person/Phone.java 93.33% <ø> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

yanghengtang commented 1 year ago

This is not allowed for v1.4

derekjxtan commented 1 year ago

This shall be planned enhancements in DG