search

AY2324S1-CS2103T-T17-1 / tp

Project Management Tool for CS2103T Project Managers
https://ay2324s1-cs2103t-t17-1.github.io/tp/
MIT License
0 stars 5 forks source link

Improve code quality #233

Closed georgetayqy closed 11 months ago

georgetayqy commented 11 months ago

This PR aims to improve the overall code quality of some pieces of code, by refactoring methods into smaller methods, and changing variable names to something more indicative of what the variable contains.

codecov[bot] commented 11 months ago

Codecov Report

Merging #233 (687052d) into master (39b5428) will decrease coverage by 0.52%. The diff coverage is 37.20%.

@@             Coverage Diff              @@
##             master     #233      +/-   ##
============================================
- Coverage     70.92%   70.41%   -0.52%     
- Complexity      568      575       +7     
============================================
  Files           101      101              
  Lines          1909     1920      +11     
  Branches        166      169       +3     
============================================
- Hits           1354     1352       -2     
- Misses          501      505       +4     
- Partials         54       63       +9
Files Coverage Δ
.../seedu/address/logic/parser/SortCommandParser.java 91.66% <ø> (ø)
src/main/java/seedu/address/ui/TaskListPanel.java 0.00% <ø> (ø)
.../seedu/address/logic/sort/enums/SortOrderEnum.java 84.61% <0.00%> (-15.39%) :arrow_down:
...a/seedu/address/logic/sort/enums/SortTypeEnum.java 88.23% <0.00%> (-11.77%) :arrow_down:
...c/main/java/seedu/address/logic/sort/SortUtil.java 67.50% <80.00%> (-7.50%) :arrow_down:
src/main/java/seedu/address/ui/TaskCard.java 0.00% <0.00%> (ø)