AY2324S1-CS2103T-T17-2 / tp

Other
1 stars 5 forks source link

Edit Command Sequence Diagram #308

Closed AlagappanRa closed 11 months ago

AlagappanRa commented 11 months ago

image

  1. Return from edit company descriptor to edit command parser should be dotted
  2. Replace

setCompany(Company target, Company editedCompany) to setCompany(target, c)

and

setCurrentViewedCompany(Company company) to setCurrentViewedCompany(c)

[This is simplistic from what actually happens, but I think its closer to the code representation].

  1. target needs to be defined now. Either

    • Refactor the code to have a single getCompanyToEdit method that encapsulates the whole method call model.getFilteredCompanyList()..get(index.getZeroBased());. Because currently, the manipulation seems like a violation of the abstraction. After that, you can use a single getCompanyToEdit from the ModelManager in the sequence diagram to show how the target company was obtained.

    • Use a seperate lifeline. (see https://github.com/nus-cs2103-AY2324S1/forum/issues/455)