search

AY2324S2-CS2103-F08-2 / tp

https://ay2324s2-cs2103-f08-2.github.io/tp/
Other
2 stars 4 forks source link

[PE-D][Tester B] Unable to hear the beep sound when clicking to the top #254

Closed nus-se-bot closed 6 months ago

nus-se-bot commented 6 months ago

To preface this, I am using mac and I could not really hear the beep sound when reaching the top of the history as written in your UG. On top of that, I can a spinning icon (I'm not sure if that is intended). Instead of beep, you could perhaps generate a message when user hits the top to counteract this issue.

Labels: type.FunctionalityBug severity.Medium original: cheahTJ/ped#6

tankh99 commented 6 months ago

Unable to reproduce

tankh99 commented 6 months ago

Actually, this is due to the issue of the sound file not being in the directory. Needs to be fixed

Jerome-j commented 6 months ago

I was thinking if this was related to the index is -1 issue?

Are there any error messages or logs being thrown when the sound file is not read in?

tankh99 commented 6 months ago

I was thinking if this was related to the index is -1 issue?

Are there any error messages or logs being thrown when the sound file is not read in?

Regarding your first point, no I don't think so? The -1 issue just failed silently. However this issue is related to the fact that the audio file is completely invisible to the built jar file. And when I tried undoing, it did indeed cause the entire application to be stuck at loading

vnnamng commented 6 months ago

@tankh99 is it an issue when compile on mac like javafx one that require specific java version?

tankh99 commented 6 months ago

@tankh99 is it an issue when compile on mac like javafx one that require specific java version?

I'm not sure if it's a platform specific issue? If you open up the JAR file and press up, that's where the issue appears. Note that this issue only appears when running the jar file and not when developing

Jerome-j commented 6 months ago

cognicarev2jar.zip Please refer to the latest one

caitlyntang commented 6 months ago

Sound is working on windows

Jerome-j commented 6 months ago

I can verify that sound is working on Windows, but it is not working on Kai Linux via WSL. I am trying out with different variants of Linux.

One more issue, if you click on arrow up, the whole application appears to freeze

caitlyntang commented 6 months ago

I did also encounter the hanging issue. If I repeatedly press the up key, the application hangs until the audio file is played an equal number of times as the up key was pressed. i.e. if the up key was pressed 11 times, the application hangs until the audio file is played 11 times

Jerome-j commented 6 months ago

Hi Khang Hou I am pleased to inform you that the sound is indeed working on Raspberry Pi