AY2324S2-CS2103-F08-3 / tp

https://ay2324s2-cs2103-f08-3.github.io/tp/
MIT License
0 stars 5 forks source link

[PE-D][Tester B] Able to add past times for meeting #191

Closed nus-se-script closed 6 months ago

nus-se-script commented 6 months ago

Command Involved meeting-add

Observation: It is possible to add meeting date and time in the past.

Steps to reproduce:

  1. Ensure there is at least 1 person in the list.
  2. Run command: meeting-add 1 s/02/02/2023 0100 d/description
  3. The meeting could be added while the time is in the past. Here is a screenshot showing the meeting in the list. doe smith.png

Rationale behind: Based on the current interpretation of the meeting-add command in the UG, it makes one feel that the intention of the meeting-add command is to add new meetings for the user. And when we think of new meetings, it is prone to interpret it as "upcoming meetings". Therefore, allowing adding meetings in the past seems in contradiction with the purpose of this command. However, after reading the "Known limitations" in the "refresh" section of the UG, I find this section "...sometimes the user would like to retain old meetings for bookkeeping purposes." It points out that users may want to record past meetings, so in this case allowing inputs of meetings in the past is reasonable. Therefore, how do you think adding this part of explanation to the meeting-add command section as it would help the users better understand your feature.


Labels: severity.Low type.FeatureFlaw original: Ella-e/ped#3

Pluiexo commented 6 months ago

Fix : Will update user guide on meeting-add that past meetings are allowed for bookkeeping purposes, in line with refresh command