AY2324S2-CS2103T-F13-2 / tp

https://nus-cs2103-ay2324s2.github.io/tp/
MIT License
0 stars 4 forks source link

Add profile panel in Ui #65

Closed ziyang27 closed 8 months ago

ziyang27 commented 8 months ago
codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 40.67797% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 78.71%. Comparing base (e851b95) to head (de71962).

Files Patch % Lines
src/main/java/seedu/address/ui/PersonProfile.java 0.00% 29 Missing :warning:
src/main/java/seedu/address/ui/MainWindow.java 0.00% 4 Missing :warning:
...rc/main/java/seedu/address/logic/LogicManager.java 0.00% 1 Missing :warning:
...rc/main/java/seedu/address/model/ModelManager.java 85.71% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #65 +/- ## ============================================ - Coverage 80.62% 78.71% -1.92% - Complexity 558 559 +1 ============================================ Files 86 87 +1 Lines 1657 1710 +53 Branches 165 168 +3 ============================================ + Hits 1336 1346 +10 - Misses 289 331 +42 - Partials 32 33 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tanyunchao commented 8 months ago

@ziyang27 is this still an PR or can this be closed?

ziyang27 commented 8 months ago

@tanyunchao still need, dun have enough code coverage to merge yet

ziyang27 commented 8 months ago

Some changes from my initial PR:

Note: The test coverage will tank a little. I implemented quite a few UI components that were not tested.

image
ziyang27 commented 8 months ago

@tanyunchao @Colex2000 ready to merge already, can help me a take a look when you free?