search

AY2324S2-CS2103T-F13-3 / tp

https://ay2324s2-cs2103t-f13-3.github.io/tp/
Other
0 stars 5 forks source link

[PE-D][Tester C] rate-mate command seems to provide a wrong error message with large index. #270

Closed nus-se-bot closed 7 months ago

nus-se-bot commented 7 months ago

Description

The UG identifies the format of delete as: rate-mate COURSEMATE -r RATING

and it produces this bug message for invalid index:

The courseMate name or index provided is not found!

When the index is even larger like #99999999999999999999999999999999999999999(unlikely but possible):

Invalid command format! rate-mate: Give a rating to a courseMate by up to five stars. COURSEMATE can be specified either by name or by the '#' notation. RATING can be specified by a single digit integer between 0 and 5, where 0 means no rating is given. Parameters: COURSEMATE -r RATING Example: rate-mate #1 -r 4

although it is a valid command format.

Steps to Reproduce

  1. Open App
  2. Type rate-mate #99999999999999999999999999999999999 -r 1
  3. See error

Expected Behavior should produce error message that

The courseMate name or index provided is not found!

Actual Behavior command format error displayed

Screenshots

image.png

image.png

Labels: type.FunctionalityBug severity.Low original: dhlee03/ped#8

benson1029 commented 7 months ago

Quoting from course website: If the problems can only happen in case of deliberate sabotage (e.g., user entered a 30-digit telephone number), in which case it should not be considered a bug.