search

AY2324S2-CS2103T-F13-3 / tp

https://ay2324s2-cs2103t-f13-3.github.io/tp/
Other
0 stars 5 forks source link

[PE-D][Tester C] add-skill command seems to provide a wrong error message with large index. #273

Closed soc-pe-bot closed 7 months ago

soc-pe-bot commented 7 months ago

Description

The UG identifies the format of add-skill as: add-skill COURSEMATE -s SKILL [-s SKILL]...

and it produces this bug message for invalid index:

The courseMate name or index provided is not found!

When the index is even larger like #99999999999999999999999999999999999999999:

Invalid command format! add-skill: Adds skills to a courseMate. CourseMates can be specified either by name or by the '#' notation. Parameters: COURSEMATE -s SKILL [-s SKILL]... Example: add-skill #1 -s Python -s Java

although it is a valid command format.

Steps to Reproduce

  1. Open App
  2. Type add-skill #999999999999999999999 -s python
  3. See error

Expected Behavior should produce error message that

The courseMate name or index provided is not found!

Actual Behavior command format error displayed

Screenshots

image.png image.png

Labels: type.FunctionalityBug severity.Low original: dhlee03/ped#11

benson1029 commented 7 months ago

Quoting from course website: If the problems can only happen in case of deliberate sabotage (e.g., user entered a 30-digit telephone number), in which case it should not be considered a bug.