AY2324S2-CS2103T-F14-4 / tp

https://nus-cs2103-ay2324s2.github.io/tp/
MIT License
0 stars 5 forks source link

[PE-D][Tester E] Support for Same Names #173

Closed soc-se-bot closed 6 months ago

soc-se-bot commented 6 months ago

SCR-20240405-rzke.png

Description

Currently, the application treats contact names as case-insensitive and does not allow duplicates, identifying "John Lim" and "john lim" as the same entity. This approach can lead to limitations in scenarios where two different contacts share the same name but differ in other attributes like phone numbers or email addresses. This restriction could prevent users from adding legitimate contacts to the system.

Steps to Reproduce

  1. Add a contact with a specific name, e.g., "John Lim"
  2. Attempt to add another contact with the same name but different casing, e.g., "john lim", and distinct attributes such as phone number and email address.
  3. Observe that the system rejects the second entry as a duplicate based on the name alone, disregarding the other attributes.

Expected Behaviour

The system should allow the addition of contacts with the same name if they have different attributes, recognizing them as separate persons. This would enable users to manage contacts more effectively, especially in cases where individuals share the same name.

Suggested Changes


Labels: severity.Medium type.FeatureFlaw original: raysonchia/ped#13

yapxuanxuan commented 6 months ago

I think this should be fine because in the course website, it is stated that names should not be case-sensitive as shown in the screenshot below image