search

AY2324S2-CS2103T-W10-2 / tp

https://nus-cs2103-ay2324s2.github.io/tp/
MIT License
1 stars 5 forks source link

[PE-D][Tester C] Missing Validation for the Search Command #246

Closed nus-pe-script closed 6 months ago

nus-pe-script commented 6 months ago

How to reproduce: Try to execute the command /search; salary: incorrectFormat or /search; phone: incorrectformat

Expected: The application should do a value validation that is similar to what add-* and edit-* would have done

Actual: There is no validation, so the application accepts the incorrectValue data to be a search query. This can lead to a user accidentally specify an incorrect field with a valid parameterValue, but ending up that there is no valid search result.

5-searchValidationPhone.png 5-searchValidationPhone2.png 5-searchValidationSalary.png 5-searchValidationSalary2.png

Labels: severity.Medium type.FunctionalityBug original: purivirakarin/ped#5

jannaleong commented 6 months ago

feature flaw - cannot be solved in v1.4