search

AY2324S2-CS2103T-W11-2 / tp

https://ay2324s2-cs2103t-w11-2.github.io/tp/
MIT License
0 stars 4 forks source link

Fix metadata null exceptions #179

Closed JuliaPoo closed 6 months ago

JuliaPoo commented 6 months ago

I attempted to manually find and handle null exceptions stemming from the optional argument in AddCommand, however, I soon gave up and decided to change Person.metadata into and Optional and let the type system tell me what to change.

Fixes #178, fixes #153, fixes #147, fixes #142, fixes #139, fixes #137, fixes #134, fixes #126

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 66.99%. Comparing base (4b9a8d7) to head (531bef0).

Files Patch % Lines
.../java/seedu/address/storage/JsonAdaptedPerson.java 50.00% 1 Missing and 2 partials :warning:
...c/main/java/seedu/address/model/person/Person.java 66.66% 2 Missing :warning:
.../java/seedu/address/logic/commands/OweCommand.java 0.00% 1 Missing :warning:
...a/seedu/address/logic/parser/AddCommandParser.java 75.00% 0 Missing and 1 partial :warning:
src/main/java/seedu/address/ui/PersonCard.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #179 +/- ## ============================================ - Coverage 67.04% 66.99% -0.05% - Complexity 546 549 +3 ============================================ Files 95 95 Lines 2118 2130 +12 Branches 214 216 +2 ============================================ + Hits 1420 1427 +7 - Misses 622 625 +3 - Partials 76 78 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.