Open Andrew22Teoh opened 3 hours ago
Attention: Patch coverage is 30.00000%
with 35 lines
in your changes missing coverage. Please review.
Files with missing lines | Coverage Δ | Complexity Δ | |
---|---|---|---|
...java/seedu/address/logic/commands/ExitCommand.java | 100.00% <100.00%> (ø) |
2.00 <1.00> (ø) |
|
...java/seedu/address/logic/commands/HelpCommand.java | 100.00% <100.00%> (ø) |
2.00 <1.00> (ø) |
|
...java/seedu/address/logic/commands/ViewCommand.java | 100.00% <100.00%> (ø) |
7.00 <0.00> (-1.00) |
|
.../seedu/address/logic/parser/ViewCommandParser.java | 100.00% <ø> (ø) |
4.00 <0.00> (ø) |
|
...va/seedu/address/logic/commands/CommandResult.java | 96.55% <92.30%> (-3.45%) |
16.00 <6.00> (+1.00) |
:arrow_down: |
src/main/java/seedu/address/ui/PersonCard.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (ø) |
|
src/main/java/seedu/address/ui/MainWindow.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (ø) |
|
...rc/main/java/seedu/address/ui/PersonListPanel.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (ø) |
|
src/main/java/seedu/address/ui/PersonCardFull.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (?) |
Hey folks, I'm quite happy with this new version of the view command.
Instead of opening a new window, this now modifies the
PersonCard
that displays information for each contact within the list of persons. This way, theViewCommand
no longer has to do afind
operation, and the persons being displayed will not change upon execution of aview
command. Furthermore, more than 1 contact may be viewed at a time now, and you can collapse the view of a person back down to its concise form by simply usingview
on an expanded index.edit
command, closing #158.Closes #142.
UG and DG including UI Class Diagram have been updated. Tests have been updated accordingly to match, but I can't really think of any additional tests to implement, so I'd love any feedback or suggestions from reviewers!
Tests to add:
isViewCommand()
method inCommandResult