AY2425S1-CS2103-F10-2 / tp

MIT License
0 stars 5 forks source link

Improved view command #167

Open Andrew22Teoh opened 3 hours ago

Andrew22Teoh commented 3 hours ago

Hey folks, I'm quite happy with this new version of the view command.

Instead of opening a new window, this now modifies the PersonCard that displays information for each contact within the list of persons. This way, the ViewCommand no longer has to do a find operation, and the persons being displayed will not change upon execution of a view command. Furthermore, more than 1 contact may be viewed at a time now, and you can collapse the view of a person back down to its concise form by simply using view on an expanded index.

Closes #142.

UG and DG including UI Class Diagram have been updated. Tests have been updated accordingly to match, but I can't really think of any additional tests to implement, so I'd love any feedback or suggestions from reviewers!

Tests to add:

codecov[bot] commented 3 hours ago

Codecov Report

Attention: Patch coverage is 30.00000% with 35 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main/java/seedu/address/ui/PersonCardFull.java 0.00% 15 Missing :warning:
...rc/main/java/seedu/address/ui/PersonListPanel.java 0.00% 12 Missing :warning:
src/main/java/seedu/address/ui/MainWindow.java 0.00% 6 Missing :warning:
...va/seedu/address/logic/commands/CommandResult.java 92.30% 1 Missing :warning:
src/main/java/seedu/address/ui/PersonCard.java 0.00% 1 Missing :warning:
Files with missing lines Coverage Δ Complexity Δ
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...java/seedu/address/logic/commands/HelpCommand.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...java/seedu/address/logic/commands/ViewCommand.java 100.00% <100.00%> (ø) 7.00 <0.00> (-1.00)
.../seedu/address/logic/parser/ViewCommandParser.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...va/seedu/address/logic/commands/CommandResult.java 96.55% <92.30%> (-3.45%) 16.00 <6.00> (+1.00) :arrow_down:
src/main/java/seedu/address/ui/PersonCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/ui/PersonListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/PersonCardFull.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)

... and 1 file with indirect coverage changes