search

AY2425S1-CS2103-F12-1 / tp

MIT License
0 stars 4 forks source link

Fixed all nits from PR 95-99 #101

Closed RezwanAhmed123 closed 2 weeks ago

RezwanAhmed123 commented 2 weeks ago

Fixed based on all the review from previous PR comments, can just merge this PR instead of having to merge all the other PRs manually.

Fixed #86 #89 #90 #91

Changed according to feedback from PR #95 #96 #98 #99

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 16.32653% with 123 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../model/client/insurance/InsurancePlansManager.java 22.00% 36 Missing and 3 partials :warning:
...in/java/seedu/address/logic/parser/ParserUtil.java 0.00% 20 Missing :warning:
...du/address/model/client/insurance/claim/Claim.java 0.00% 20 Missing :warning:
...du/address/logic/parser/AddClaimCommandParser.java 0.00% 15 Missing :warning:
.../seedu/address/logic/commands/AddClaimCommand.java 0.00% 14 Missing :warning:
src/main/java/seedu/address/logic/Messages.java 0.00% 4 Missing :warning:
...du/address/logic/commands/AddInsuranceCommand.java 42.85% 3 Missing and 1 partial :warning:
.../java/seedu/address/storage/JsonAdaptedClient.java 50.00% 2 Missing and 1 partial :warning:
...ddress/model/client/exceptions/ClaimException.java 0.00% 2 Missing :warning:
...address/logic/commands/DeleteInsuranceCommand.java 0.00% 1 Missing :warning:
... and 1 more
Files with missing lines Coverage Δ Complexity Δ
...odel/client/exceptions/InsurancePlanException.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
.../address/model/client/insurance/InsurancePlan.java 87.50% <100.00%> (+4.16%) 6.00 <0.00> (ø)
...s/model/client/insurance/InsurancePlanFactory.java 72.72% <100.00%> (ø) 5.00 <0.00> (ø)
...address/logic/commands/DeleteInsuranceCommand.java 22.22% <0.00%> (ø) 3.00 <0.00> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 91.30% <0.00%> (-8.70%) 14.00 <0.00> (ø)
...ddress/model/client/exceptions/ClaimException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/seedu/address/storage/JsonAdaptedClient.java 94.64% <50.00%> (-5.36%) 12.00 <0.00> (ø)
src/main/java/seedu/address/logic/Messages.java 72.72% <0.00%> (-16.17%) 3.00 <0.00> (ø)
...du/address/logic/commands/AddInsuranceCommand.java 21.42% <42.85%> (ø) 3.00 <1.00> (ø)
.../seedu/address/logic/commands/AddClaimCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 4 more
yanqiyqh commented 2 weeks ago

Fixes issues #89, fixes #90 and fixes #91