AY2425S1-CS2103-F12-1 / tp

MIT License
0 stars 4 forks source link

Update UI and storage #75

Closed zi-yii closed 3 weeks ago

zi-yii commented 3 weeks ago

Found some error with the saving of added insurance date when trying to implement UI.

For the storage, when a client is first added to the address book, insurance plans will be shown as "No added plans". If insurance plans are added, they will be stored as a string.

For example if both basic and travel insurance plans are added to client A, insurance plans will be saved and displayed as "Basic Insurance plan, Travel Insurance plan" (the order depends on which insurance plan is added first).

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 50.76923% with 64 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...address/logic/commands/DeleteInsuranceCommand.java 25.00% 15 Missing and 3 partials :warning:
...du/address/logic/commands/AddInsuranceCommand.java 0.00% 17 Missing :warning:
.../model/person/insurance/InsurancePlansManager.java 57.14% 13 Missing and 2 partials :warning:
...s/model/person/insurance/InsurancePlanFactory.java 27.27% 7 Missing and 1 partial :warning:
...ess/logic/parser/DeleteInsuranceCommandParser.java 63.63% 3 Missing and 1 partial :warning:
...java/seedu/address/logic/commands/EditCommand.java 93.75% 0 Missing and 1 partial :warning:
src/main/java/seedu/address/ui/PersonCard.java 0.00% 1 Missing :warning:
Files with missing lines Coverage Δ Complexity Δ
src/main/java/seedu/address/logic/Messages.java 88.88% <100.00%> (+1.38%) 3.00 <0.00> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <100.00%> (ø) 14.00 <0.00> (+1.00)
...in/java/seedu/address/logic/parser/ParserUtil.java 92.85% <ø> (-4.93%) 15.00 <0.00> (ø)
...c/main/java/seedu/address/model/person/Person.java 97.36% <100.00%> (+0.14%) 20.00 <1.00> (+1.00)
.../address/model/person/insurance/InsurancePlan.java 66.66% <ø> (-6.07%) 5.00 <0.00> (-2.00)
.../java/seedu/address/model/util/SampleDataUtil.java 20.00% <ø> (ø) 1.00 <0.00> (ø)
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <100.00%> (ø) 12.00 <0.00> (+1.00)
...java/seedu/address/logic/commands/EditCommand.java 97.50% <93.75%> (+0.06%) 13.00 <1.00> (ø)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 5 more
RezwanAhmed123 commented 3 weeks ago

fixes #52