Closed RezwanAhmed123 closed 2 weeks ago
Attention: Patch coverage is 9.58904%
with 66 lines
in your changes missing coverage. Please review.
Files with missing lines | Coverage Δ | Complexity Δ | |
---|---|---|---|
...du/address/logic/commands/AddInsuranceCommand.java | 21.42% <ø> (ø) |
3.00 <0.00> (ø) |
|
...ain/java/seedu/address/logic/parser/CliSyntax.java | 88.88% <100.00%> (+3.17%) |
1.00 <0.00> (ø) |
|
.../address/model/person/insurance/InsurancePlan.java | 87.50% <100.00%> (+4.16%) |
6.00 <0.00> (ø) |
|
.../seedu/address/logic/parser/AddressBookParser.java | 91.30% <0.00%> (-8.70%) |
14.00 <0.00> (ø) |
|
src/main/java/seedu/address/logic/Messages.java | 80.00% <0.00%> (-8.89%) |
3.00 <0.00> (ø) |
|
.../model/person/insurance/InsurancePlansManager.java | 65.21% <11.11%> (-13.17%) |
15.00 <0.00> (ø) |
|
...in/java/seedu/address/logic/parser/ParserUtil.java | 73.58% <0.00%> (-19.28%) |
15.00 <0.00> (ø) |
|
.../seedu/address/logic/commands/AddClaimCommand.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (?) |
|
...du/address/logic/parser/AddClaimCommandParser.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (?) |
|
...du/address/model/person/insurance/claim/Claim.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (?) |
refer to PR #101
Claim object does not exist and it is hard to pack all these data about claims together without abstraction.
Let's create a claim object to Insurance Plan object and format the error messages to not be magic literals.
This will make further development easier.