search

AY2425S1-CS2103-F12-3 / tp

Other
0 stars 4 forks source link

[PE-D][Tester A] Filter does not stay after edit command #250

Closed nus-pe-script closed 4 days ago

nus-pe-script commented 1 week ago

Currently filter applied does not stay after an edit command is given. Given that both list and edit reset the filters, the reset all filters button is not very useful.

Steps to replicate: use a command to filter (I used tags), then use an edit command (w Expected: the filter still applies to the list Actual: the filter is lifted.

screenshots: After tags chinese:

image.png

After edit 1 t/chinese t/halal:

image.png

Labels: type.FeatureFlaw severity.Medium original: FionaQY/ped#8

JagdeepSinghNUS commented 5 days ago

There are two ways I was thinking we can solve this, the first is to code it such that it solves the issue, the second way is to update the User Guide for tags, find, price commands by adding a tip, where we explain if you edit any restaurants, the filter will automatically reset.

WeiHanWong commented 5 days ago

This is not a flaw, is an intended feature, which is present from AB3

AmadeusEka commented 4 days ago

I think it’s better to update the User Guide to clarify that the edit feature intentionally removes any filters, ensuring that the edited restaurant is immediately displayed in the list.

shotnothing commented 4 days ago

This is not a flaw, is an intended feature, which is present from AB3

ngl half of the bugs stem from AB3