Closed jan-kai1 closed 1 day ago
Attention: Patch coverage is 88.50575%
with 10 lines
in your changes missing coverage. Please review.
Files with missing lines | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/main/java/seedu/address/logic/Messages.java | 85.71% <100.00%> (+2.38%) |
4.00 <0.00> (ø) |
|
.../java/seedu/address/logic/commands/AddCommand.java | 100.00% <ø> (ø) |
8.00 <0.00> (ø) |
|
...java/seedu/address/logic/commands/EditCommand.java | 95.65% <100.00%> (+1.53%) |
18.00 <0.00> (ø) |
|
...a/seedu/address/logic/parser/AddCommandParser.java | 100.00% <100.00%> (ø) |
5.00 <0.00> (ø) |
|
...in/java/seedu/address/logic/parser/ParserUtil.java | 88.88% <100.00%> (+1.70%) |
16.00 <2.00> (+2.00) |
|
...rc/main/java/seedu/address/model/ModelManager.java | 100.00% <ø> (ø) |
25.00 <0.00> (ø) |
|
...c/main/java/seedu/address/model/person/Person.java | 95.83% <100.00%> (+2.97%) |
31.00 <4.00> (+4.00) |
|
src/main/java/seedu/address/model/role/Role.java | 100.00% <100.00%> (ø) |
14.00 <1.00> (+1.00) |
|
...ain/java/seedu/address/model/role/RoleHandler.java | 100.00% <100.00%> (ø) |
10.00 <5.00> (ø) |
|
...ss/model/role/exceptions/InvalidRoleException.java | 100.00% <100.00%> (ø) |
1.00 <1.00> (ø) |
|
... and 5 more |
Updated #71 to resolve conflicts with master branch after Tag removal RoleHandler RoleHandler.getRole changed to a static method. Since it accesses static fields which are constant across all RoleHandler instances and isValidRole is static, makes more sense getRole method should be static as well
Person Person constructor takes in a varargs of Role ... (Unsure if should make roles mandatory) Person Constructor takes in a Set
Person instance now has a Set along with methods getRoles() and hasRole In line with existing edit command process (which creates a new Person instance and replaces the existing one in addressBook), Person currently does NOT have any methods to set or change the existing roles. This can be changed based on later implementation of addRole command.
Add and Edit Commands Now supports addition of roles, currently have to input each role individually e.g. /r vendor /r attendee
JsonAdaptedRole Takes in any string with no checks, exception only thrown when toModelType() is called