AY2425S1-CS2103T-F12-1 / tp

MIT License
0 stars 5 forks source link

[PE-D][Tester E] Hyphenated and non-hyphenated phone numbers with the same numerical values are registered as distinct phone numbers #285

Closed soc-pe-bot closed 2 days ago

soc-pe-bot commented 4 days ago

Steps to reproduce:

  1. Open contactcs.jar.
  2. Enter clear to clear the address book.
  3. Execute the following commands in sequence. These commands add 3 separate contacts to the address book. All three contacts share the same contact number in different format.

Expected result: The error message "This email or phone is already used by a person in the address book." should appear. The second contact should not be added to the address book.

Actual result: Both contacts are successfully added to the address book.

Screenshot of issue: Screenshot 2024-11-08 at 5.30.00 PM.png


Labels: type.FeatureFlaw severity.Medium original: frymash/ped#8

lithops-zty commented 3 days ago

An enhancement. Not in scope.

the supposedly 'better' implementation will take more effort than the current implementation, reducing the effort available to spend on other more important tasks

doing such complicated phone number is hard.

In addition, the following (at least one) need to be satisfied: The UG specifies it as not supported or coming in a future version.

We will clarify that only exactly the same phone numbers will be flagged as duplicates, in UG.