AY2425S1-CS2103T-F12-3 / tp

MIT License
3 stars 5 forks source link

Make fields private and replace access with getters / setters to maintain SOLID principles #84

Open yadobler opened 7 hours ago

yadobler commented 7 hours ago

Had the same idea, but went through with following the standard convention of other classes under model/person where all the values are public. Had I set it to private my getters would have to be different name as we would then need 2 getters to get the actual priority in String format (i.e first getter to get Priority class object from Person object, then second getter to get the String value) making the test cases less comprehensible, as such decide to go with the flow to ensure readability as well as standardizations throughout test cases.

_Originally posted by @PresleyChew in https://github.com/AY2425S1-CS2103T-F12-3/tp/pull/82#discussion# r1795445550

This seems to be an issue throughout the project, need to address it.