search

AY2425S1-CS2103T-F14b-3 / tp

MIT License
0 stars 5 forks source link

[PE-D][Tester E] Error message for NRIC can be clearer #223

Open nus-pe-bot opened 2 hours ago

nus-pe-bot commented 2 hours ago

Summary: The error messages for the NRIC field for add and edit is too general.

image.png

Perhaps you can tell the users exactly what is wrong with the NRIC addition, otherwise this feature might be quite hard to test as users might only know their own NRIC.

Labels: type.FeatureFlaw severity.Medium original: weijianwong/ped#6

Zenkoh1 commented 2 hours ago

imo, its not possible, because

while for other fields like name or address or date, the format error is given to you so the user can adjust his/her input to adhere to the constraints (eg. leave out certain characters)

but for NRIC, it is a fixed identification number given to you by the government. So, you can't be like, oh hmm let's adjust this NRIC a bit to adhere to the constraints, its either correct, or just wrong

this is my best argument (ie. for actual PE) thoughts?