AY2425S1-CS2103T-T15-1 / tp

Other
0 stars 5 forks source link

Implement UI for rental information list #126

Closed zackjh closed 2 weeks ago

zackjh commented 2 weeks ago

Fixes #115

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...n/java/seedu/address/ui/RentalInformationCard.java 0.00% 8 Missing :warning:
...eedu/address/logic/commands/ViewRentalCommand.java 0.00% 5 Missing :warning:
...a/seedu/address/ui/RentalInformationListPanel.java 0.00% 5 Missing :warning:
...rc/main/java/seedu/address/model/ModelManager.java 40.00% 3 Missing :warning:
src/main/java/seedu/address/ui/MainWindow.java 0.00% 1 Missing :warning:
Files with missing lines Coverage Δ Complexity Δ
...rc/main/java/seedu/address/logic/LogicManager.java 78.26% <100.00%> (+0.98%) 4.00 <1.00> (+1.00)
src/main/java/seedu/address/logic/Messages.java 74.35% <ø> (ø) 5.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 89.09% <40.00%> (-4.91%) 24.00 <1.00> (+1.00) :arrow_down:
...eedu/address/logic/commands/ViewRentalCommand.java 22.72% <0.00%> (-5.06%) 2.00 <0.00> (ø)
...a/seedu/address/ui/RentalInformationListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...n/java/seedu/address/ui/RentalInformationCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
zackjh commented 2 weeks ago

Codecov check is failing because most of the updated files were UI-related files which are difficult to test.

https://nus-cs2103-ay2425s1.github.io/website/admin/appendixC-faq.html#faq-pr-ci-fails-because-codecov-reports-a-drop-in-code-coverage-what-to-do