search

AY2425S1-CS2103T-T16-3 / tp

MIT License
0 stars 5 forks source link

[PE-D][Tester E] Potential error in Model component class diagram #360

Closed soc-pe-bot closed 2 days ago

soc-pe-bot commented 3 days ago

Given how Group contains Persons (based on my inference), I think there may be a missing association between the Group and Person class.

Of course, this issue may be inaccurate as the association between Group and Person is inferred by myself based on the functionality of the group (I assume that Group contains Person objects).

image.png

Labels: type.DocumentationBug severity.Low original: tingxuanp/ped#9

seah-minlong commented 3 days ago

I don't remember group having such an association? Tagging @voldiemort for your input, can close this issue if it's inaccurate.

voldiemort commented 2 days ago

I believe the inheritance of Group from UniquePersonList already implies the association? Do you think we should make it explicit instead?

seah-minlong commented 2 days ago

Yeah I think you are right. I shall close this issue.