search

AY2425S1-CS2113-T10-2 / tp

0 stars 5 forks source link

[PE-D][Tester D] No input validation for addVisit command #318

Closed nus-pe-bot closed 1 week ago

nus-pe-bot commented 1 week ago

Good enforcement of ensuring only existing patients can have visit records added! Small issue with the input validation for diagnosis and medications.

Picture10.png

Steps to replicate:

add n/Patricia Chan ic/S9890897U v/04-11-2024 09:00 addVisit ic/S9890897U v/22-10-2024 09:30 d/~!~!!~ m/~!~!~1`!~!

Labels: type.FeatureFlaw severity.Medium original: lucas-sc0/ped#9

kaboomzxc commented 1 week ago

Thank you for positive feedback, yes, we enforce and ensure only existing patients can have visit records added.

yes, we save diagnosis and medications as strings, and in fact there are many examples of Diagnoses and Medications with special characters. so unfortunately it is not a good idea to ban special characters.

Examples : Ménière's disease Ehlers-Danlos syndrome

Vitamin B₁₂ 5-Fluorouracil L-thyroxine α-Tocopherol D₅W 17β-Estradiol