search

AY2425S1-CS2113-T10-4 / tp

1 stars 4 forks source link

[PE-D][Tester B] set-budget does not correctly process large, edge case budget amounts #154

Closed nus-pe-script closed 3 weeks ago

nus-pe-script commented 3 weeks ago

image.png

The set-budget command incorrectly alters/rounds up budgets that are beyond a certain amount. As shown in the attachment, the erronous behaviour seems to manifest differently depending on the amount provided (i.e. when 9999999999999991 is input, 9999999999999992 is stored, but when 10000000000000001111111 is input, 10000000000000002000000 is stored.

This is unlikely to impact most users functionality, but is still a bug that deviates from expected behaviour and thwarts users entering seemingly permitted use-case.

A suggestion, if this limitation arises from variable bit-size limitations, may just be to enforce an upper limit at a certain reasonable amount.

Please that one of the values in the attachement (the first) actually processes correctly, it's just amounts larger than that fail.

Labels: severity.Medium type.FunctionalityBug original: Yvorm/ped#3

MayFairMI6 commented 3 weeks ago

I have set an upper limit of 1 quadrillion (1,000,000,000,000,000)