AY2425S1-CS2113-W14-3 / tp

0 stars 5 forks source link

[PE-D][Tester A] Invalid price validation when editing expense values breaks budget tracking #234

Closed nus-pe-script closed 3 hours ago

nus-pe-script commented 6 hours ago

Scenario

If an out of range (above 9999999.01) is entered when editing an expense.

Validation is done but the current monthly balance breaks. In the scenario below, the current monthly balance is supposed to remain at $96.50 but it instead jumps to $ -9999899.01

--------------------------------------------
Welcome to FinanceBuddy!
Your one stop solution for financial peace of mind
How can I help you today? :)
--------------------------------------------

--------------------------------------------
Would you like to set a budget? (yes/no)
--------------------------------------------
yes
--------------------------------------------
Please set your budget amount:
--------------------------------------------
100
--------------------------------------------
Your budget has successfully been set to: $ 100.00
Your current monthly balance is: $ 100.00
--------------------------------------------
expense food /a 3.50
--------------------------------------------
Got it! I've added this expense:
[Expense] - food $ 3.50 (on 08/11/24) [UNCATEGORIZED]
--------------------------------------------
Your current monthly balance is: $ 96.50
--------------------------------------------
edit 1 /a 9999999.01
Your current monthly balance is: $ 100.00
--------------------------------------------
You have exceeded your monthly budget of: $ 100.00!
Your current monthly balance is: $ -9999899.01
--------------------------------------------
Invalid amount. Amount must be $9999999.00 or less.
list
--------------------------------------------
Here's a list of all recorded entries:
1. [Expense] - food $ 3.50 (on 08/11/24) [UNCATEGORIZED]

Net cashflow: $ -3.50

Highest Expense Category: UNCATEGORIZED ($3.50)
Highest Income Category: UNCATEGORIZED ($0.00)
--------------------------------------------
Your current budget is: $ 100.00
Your current monthly balance is: $ -9999899.01
--------------------------------------------

Suggestions

There is most likely a desync in how the current monthly balance is updated, it updates before the validation check.

Other - Screenshot

image.png


Labels: severity.Low type.FunctionalityBug original: Hackin7/ped#3