search

AZO234 / NP2kai

Neko Project II kai
http://domisan.sakura.ne.jp/article/np2kai/np2kai.html
MIT License
246 stars 61 forks source link

Fixed an error when building an SDL port with MSYS2 of Windows. #114

Closed miyamoto999 closed 3 years ago

miyamoto999 commented 3 years ago

SDLポートをWindowsのMSYS2でビルドしてみたら、エラーになったので直してみました。 ただし、VS2019でビルドした場合はエラーにならないんで、SUPPORT_SJISが定義されているのがそもそも正しいのか？って疑問が。

When I build the SDL port with MSYS2 of Windows, I got an error, so I fixed it. However, I didn't get an error then I build it with VS2019, so is it correct that SUPPORT_SJIS is defining? That's the question.

AZO234 commented 3 years ago

Yes! Thanks to your fix! Anyway SUPPORT_SJIS is defiled or not, building must be success...

I think SUPPORT_SJIS is needed for old Windows. (Cause that, VS2019 port has to be defined SUPPORT_SJIS. 😅) On NP2kai, all text literals are code by UTF-8 now.

いつもありがとうございます！ 他にも修正などがありましたら、ジャンジャンお願いします！ 🎉

miyamoto999 commented 3 years ago

じゃんじゃん送ります😀