AZO234 / NP2kai

Neko Project II kai
http://domisan.sakura.ne.jp/article/np2kai/np2kai.html
MIT License
254 stars 62 forks source link

win32 libretro build fixes #58

Closed orbea closed 6 years ago

orbea commented 6 years ago

These are some windows 64-bit and 32-bit build fixes for the libretro port, I do not use windows so I tested this in the libretro fork with the buildbot where the builds succeeded.

Please see https://github.com/libretro/NP2kai/pull/3, https://github.com/libretro/NP2kai/pull/4 and https://github.com/libretro/NP2kai/pull/5.

These are the build errors for reference.

Build failure

../sdl2/dosio.c: In function 'file_dircreate':

../sdl2/dosio.c:193:16: error: too many arguments to function 'mkdir'

  return((short)mkdir(path, 0777));

                ^~~~~

In file included from ../sdl2/libretro/libretro-common/include/retro_dirent.h:41:0,

                 from ../sdl2/dosio.c:10:

C:/msys64/mingw32/i686-w64-mingw32/include/direct.h:59:15: note: declared here

   int __cdecl mkdir(const char *_Path) __MINGW_ATTRIB_DEPRECATED_MSVC2005;

               ^~~~~

make: *** [Makefile.libretro:326: ../sdl2/dosio.o] Error 1

Warnings.

In file included from ../sound/fmgen/fmgen_types.h:4:0,

                 from ../sound/fmgen/fmgen_fmgen.h:10,

                 from ../sound/fmgen/fmgen_opm.h:10,

                 from ../sound/fmgen/fmgen_opm.cpp:9:

../sdl2/libretro/compiler.h:243:0: warning: "FASTCALL" redefined

 #define FASTCALL

In file included from C:/msys64/mingw32/i686-w64-mingw32/include/minwindef.h:163:0,

                 from C:/msys64/mingw32/i686-w64-mingw32/include/windef.h:8,

                 from C:/msys64/mingw32/i686-w64-mingw32/include/windows.h:69,

                 from ../sdl2/libretro/compiler.h:35,

                 from ../sound/fmgen/fmgen_types.h:4,

                 from ../sound/fmgen/fmgen_fmgen.h:10,

                 from ../sound/fmgen/fmgen_opm.h:10,

                 from ../sound/fmgen/fmgen_opm.cpp:9:

C:/msys64/mingw32/i686-w64-mingw32/include/winnt.h:262:0: note: this is the location of the previous definition

 #define FASTCALL __fastcall
AZO234 commented 6 years ago

Yes, thanks to yor fix! Please make libretro a good fix as well.

orbea commented 6 years ago

Thanks! The libretro fix has already been made. :)