search

AZO234 / NP2kai

Neko Project II kai
http://domisan.sakura.ne.jp/article/np2kai/np2kai.html
MIT License
254 stars 62 forks source link

[Libretro] fail to compile #66

Open Tatsuya79 opened 5 years ago

Tatsuya79 commented 5 years ago

Hello, I just tried to compile the libretro core under Mingw64 GCC 7.3 Win7 x64 but its failing. log here (I removed some lines as it was too big near the end, I kept the errors and warnings)

Thank you.

Tatsuya79 commented 5 years ago

Also if you want us to pull from your repo we can do it. It's up to you (if you have time to look into the build issues with the buildbot then or not).

AZO234 commented 5 years ago

Hi, Tetsuya! I replaced libretro-common files, then because of that, errors has occurred. I would like to use buildbot to solve errors.

Can you temporarily connect my repository to buildbot? Maybe I have to look running build sequence several times. Once resolved, please return the connection to libretro/NP2kai. And pull to libretro/NP2kai at that time.

I will leave the way.

Thanks!

Tatsuya79 commented 5 years ago

Ok, the buildbot is set to your repo now: https://github.com/libretro/libretro-super/commit/7bb5ac82090b109947bc36e943a0a2a09a7e3fa7

AZO234 commented 5 years ago

Thanks to your kindness! :heart: Then I'll contact again here when I debug done.

inactive123 commented 5 years ago

Some suggestions to fix some of the build failures -

this one is for Switch/libnx -

/opt/devkitpro/devkitA64/lib/gcc/aarch64-none-elf/8.2.0/../../../../aarch64-none-elf/bin/ld: libretro_libnx.a(sxsihdd_nvl.o): in function nvl_close': /home/buildbot/buildbot/libnx/libretro-np2kai/sdl2/../fdd/sxsihdd_nvl.c:103: undefined reference todlclose'

I would not compile in any code for the libretro port that relies on dynamic loading like this, at least not for the game consoles. dlclose/dlopen/dlsym will not be available there by default, and for the few platforms where such functionality is available, it is most likely through alternative function calls. So again, I would deal with this by just not compiling these parts in.

carlos-hoyos commented 5 years ago

Will fixing this make the core work again in Vita? I would love to help making it compatible again, but the workload I have these months barely gives me enough time to breath. If there was a bounty, I would chip in.

AZO234 commented 5 years ago

To twinaphex. Yes, that is dynamic loading for expand storage type. But that is not necessary and maybe danger function to RA. I'll make be not call.

To carlos-hoyos Currently, the NP2kai core is in an unstable state due to adjustment. But I was able to build for Vita. Check nightly files.

To Tatsuya79 Please pull to libretro/NP2kai, please. Let's switch the fetch of buildbot to libretro/NP2kai. There were many problems, so I will adjust it for a while. I will ask you when I want to change again.

Tatsuya79 commented 5 years ago

If you want to test locally to build for libnx (Nintendo Switch) there is a guide here: https://docs.libretro.com/compilation/switch-libnx/

I made a PR for the buildbot to build from libretro: https://github.com/libretro/libretro-super/pull/975

Then perhaps send a PR to libretro/NP2kai with your updates? I don't know how to do it myself.

AZO234 commented 5 years ago

Yeah, thank you so much.

Then I'm trying to libretro-super local build environments! 3 OSs, so many devkit... XD

I didn't tune source files, I'll PR to LR board when next some large implementation.

Tatsuya79 commented 5 years ago

Hello thanks for your effort to fix Np2kai on many systems!

Message from Autechre about emscripten:

retroarch: [status: fail] [recipes/emscripten/emscripten] LOG: http://p.0bl.net/105991 basically what needs to happen is that libretro-common files like nbio need to not be compiled in if STATIC_LINKING is enabled I can show an example of how to do this in a Makefile here is an example: https://github.com/libretro/beetle-psx-libretro/blob/master/Makefile.common#L246

AZO234 commented 5 years ago

I'm sorry for occurred link error.

I referenced to some projects for implementing to libretro. I didn't know making static library for Emscripten...

I could fix, pushed to this repository. Would Testuya-san pull to libretro/NP2kai?

Always thank you.

Tatsuya79 commented 5 years ago

I see It successfully compiled with your last PR, so it's fine now. Thank you!