search

AZO234 / NP2kai

Neko Project II kai
http://domisan.sakura.ne.jp/article/np2kai/np2kai.html
MIT License
246 stars 61 forks source link

Large file support broken? #76

Open yksoft1 opened 4 years ago

yksoft1 commented 4 years ago

I saw file_seek() in dosio.c of both x11 and sdl2 target is using 32-bit file pointer and fseek()/ftell(). Thus, the definition of FILEPOS for large file support in compiler.h is not respected at all. file_getsize() has the same problem.

yksoft1 commented 4 years ago

I tried in https://github.com/yksoft1/NP2kai/commit/8584060583c8d92b2daf533ce1d295e0d79e2480 and it booted my 2.1GB Windows 2000 vhd image.

AZO234 commented 4 years ago

Thanks, and Sorry to reply too late!! I check that!

AZO234 commented 4 years ago

I saw your change files, and 'emscripten' branch... Awesome! I wanna merge whole these changes, after checking. Thanks to your wide coverage, and I sorry my lazy to you...

I need to add you to some text as POWERFUL development member, but already written in Git log, and I do a short writing. I just apologize.

I start the build check, it will take time again. It also includes changes by other people who have forked NP2kai.

Best regard.

AZO234 commented 4 years ago

I pushed yksoft1@8584060. I modified a bit your code. It included other your fixes too.

I'll look and try your code Emscripten future.

THANK YOU VERY MUCH!!