Add options to configure entity-cards

AalianKhan / mushroom-strategy

A strategy to automatically generate a dashboard using mushroom cards

MIT License

371 stars 37 forks source link

Add options to configure entity-cards #31

Closed DigiLive closed 1 year ago

DigiLive commented 1 year ago

Closes #10.

Option to set the type of entity card.
Option to hide an entity card from the dashboard.

DigiLive commented 1 year ago

Looks good 👍 I see that when I define a card in card options, it merges the default card config and my custom card config. Would it be better if it discards the default config and only uses the custom config?

That was how it was before, but this means users will run in trouble when they forget mandatory properties (for example). IMHO this way is more fail-save.

ajagnanan commented 1 year ago

Any eta for this one guys?

DigiLive commented 1 year ago

Any eta for this one guys?

I can't finish up the PR without approval of @AalianKhan since reviews are required.

@AalianKhan Could you please review or change the requirement so I can merge the PR and create an alpha.2 pre-release?

AalianKhan commented 1 year ago

Sorry about that, was busy with life for a few days.