search

AalianKhan / mushroom-strategy

A strategy to automatically generate a dashboard using mushroom cards
MIT License
371 stars 37 forks source link

Configure chip actions #38

Closed Leithian closed 9 months ago

Leithian commented 1 year ago

I found it confusing that some chips directly navigate when tapping/clicking while others will perform an action. This has caused me to turn off all my lights/switches multiple times, causing some problems.

I've added an option to swap the tap and hold actions where applicable.

If I'm the only one with this problem feel free to close this PR, I can keep my own private version.

DigiLive commented 1 year ago

It's probably all ok, but let me check also tomorrow.

It seems odd to have no default options configured, but always creating the same property in the constructor.

DigiLive commented 1 year ago

Review comments for FanChip.js, also apply to the other chip classes.

BertHankes commented 10 months ago

The switch chip is, in my case, a dangerous chip.. When clicking on it, it triggers all the switches so that the fuses blow!

BTW: the fuses don't blow. One of the switches that turned off was a sort of main switch in my fuse box. My bad :-)

Resolved with chips: switch_count: false Now the chip is not shown!

DigiLive commented 10 months ago

The switch chip is, in my case, a dangerous chip.. When clicking on it, it triggers all the switches so that the fuses blow!

This PR is pretty much stale... What do you suggest for improving the chips? Please discuss it in the discussions section or create an issue.

DigiLive commented 9 months ago

Closed for being stale.