AalianKhan / mushroom-strategy

A strategy to automatically generate a dashboard using mushroom cards
MIT License
364 stars 36 forks source link

Add Magic areas + chips #76

Closed adrienbrault closed 8 months ago

adrienbrault commented 10 months ago

Hey,

This includes #75, with the addition of chips for lights, climate, motion and media players.

Here's what it looks like:

This is a start, WDYT?

DigiLive commented 10 months ago

Tanks you for your effort :)

So, if I understand correctly... This PR replaces #75 which replaces #44? The other two can be closed?

Could you please add doc-blocks for the added functions/methods, comments to explain the purpose of the pieces of code and also refactor variable/property names into more descriptive ones. E.g. const lock = ... into const lockId = ...

PS: Don't push content of the dist directory. It will create a merge conflict.

adrienbrault commented 9 months ago

So, if I understand correctly... This PR replaces #75 which replaces #44? The other two can be closed?

75 does replace #44.

And this one includes the commits from #75. But I'd rather get #75 merged first, since #76 isn't quite ready yet IMHO.

Specifically, this MR adds 2 new requirements:

And I wish the AreaCard could automatically create a chip for all lights/media_players/etc, without requiring a group to be configured.

Could you please add doc-blocks for the added functions/methods, comments to explain the purpose of the pieces of code and also refactor variable/property names into more descriptive ones. E.g. const lock = ... into const lockId = ...

PS: Don't push content of the dist directory. It will create a merge conflict.

Noted, I will, on #75 first ;-) !

DigiLive commented 8 months ago

[!WARNING] The main branch has been switched to TypeScript. Update your feature branch accordingly!

adrienbrault commented 8 months ago

Hey, closing as I won't be working more on this implementation.

I am exploring a different approach: https://github.com/adrienbrault/ha-jsx-strategy