Use Mushroom Number Card for number entities

[punxaphil]

Support number entities by using the Mushroom Number Card.

Before:

After:

[DigiLive]

You're doing great. Thank you very much for your cooperation on enhancing the strategy.

FYI... My advice is to commit unrelated changes separately. E.g., The type fix in the readme has nothing to do with the creation of your new card.

I'd have committed:

• The additions in the type definitions.
• The creation of the new class.
• The additions in the defaults.
• The changes in the documentation.
• etc.

In such way you can make a more effective use of history-tracking, like rolling-back or consulting changes. Once we merge the branch into the main branch, we can squash the commits into a single one to keep the history clean.

[punxaphil]

My advice is to commit unrelated changes separately.

Alright, I'll ignore the boy scout rule then 😄 I have now reverted the doc fix.

[DigiLive]

My advice is to commit unrelated changes separately.

Alright, I'll ignore the boy scout rule then 😄 I have now reverted the doc fix.

I apply the boy scout also, but mostly when I have to make changes to the file already. Then I try to divide it over several commits... E.g., 1 for adding documentation and 1 for fixing typos.

https://github.com/DigiLive/gitChangelog/wiki/1-Introduction is my rule of thumb.

[punxaphil]

Ok, but does that matter with separate commits? Since it's gonna be merge squashed anyway. 🙂

[DigiLive]

Once we merge into the main branch, yes. But then, in theory, all code is ok.

It's more about committing while developing. A bit of explanation here: https://gist.github.com/luismts/495d982e8c5b1a0ced4a57cf3d93cf60

[punxaphil]

Alright, documentation fix pushed again, now in its own commit. All good?

[DigiLive]

We were good all along in my opinion. It's just meant as advice not as criticism. I'm glad you're helping out. 👍🏻

Did you want me to do something like a review or so, or is this PR just in advance, like a draft?

[punxaphil]

Ok! It's ready in my mind. So feel free to review and merge if you like it.